mikeb mikeb has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30756 )
Change subject: AGESA/PI: replace HUDSON_DISABLE_IMC with HUDSON_IMC_ENABLE
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/30756/2/src/vendorcode/amd/Kconfig
File src/vendorcode/amd/Kconfig:
https://review.coreboot.org/#/c/30756/2/src/vendorcode/amd/Kconfig@a32
PS2, Line 32:
This seems to be lost in this change.
I lost it on purpose because now it is opt-in regarding the IMC:
unless you select HUDSON_IMC_ENABLE it will not be enabled for them.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30756
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3590b13c3b155405d61e373daf1bd82ca8e3bd16
Gerrit-Change-Number: 30756
Gerrit-PatchSet: 2
Gerrit-Owner: mikeb mikeb
mikebdp2@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: Rudolf Marek
r.marek@assembler.cz
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mikeb mikeb
mikebdp2@gmail.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 13 Jan 2019 14:14:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment