Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34166 )
Change subject: soc/intel/{cnl,icl}: Drop insane defaults for CAR implementation
......................................................................
Patch Set 1:
I don't follow. This patch already sets `USE_CANNONLAKE_
CAR_NEM_ENHANCED` as default (just implicitly because the
first entry of a choice is always the default). If you
want me to add an unnecessary but explicit `default
USE_CANNONLAKE_CAR_NEM_ENHANCED`, let me know.
However, in that case I would also like to make it a con-
vention. General Kconfig style shouldn't be part of this
review. Somebody would have to write a lint test to check
for choices without explicit default and we should discuss
if that is what we want for the project.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34166
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4a880f3093887628ce6bc9c39758e43688345713
Gerrit-Change-Number: 34166
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Boon Tiong Teo
boon.tiong.teo@intel.com
Gerrit-Reviewer: Lean Sheng Tan
lean.sheng.tan@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Teo Boon Tiong
boon.tiong.teo@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 12 Jul 2019 10:37:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment