build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34505 )
Change subject: mediatek/mt8183: add a new panel configuration for Kodama ......................................................................
Patch Set 10:
(16 comments)
https://review.coreboot.org/c/coreboot/+/34505/10/src/mainboard/google/kukui... File src/mainboard/google/kukui/panel_kodama.c:
https://review.coreboot.org/c/coreboot/+/34505/10/src/mainboard/google/kukui... PS10, Line 34: .name = "1200x1920@60Hz", code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34505/10/src/mainboard/google/kukui... PS10, Line 34: .name = "1200x1920@60Hz", please, no space before tabs
https://review.coreboot.org/c/coreboot/+/34505/10/src/mainboard/google/kukui... PS10, Line 35: .pixel_clock = 156297, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34505/10/src/mainboard/google/kukui... PS10, Line 35: .pixel_clock = 156297, please, no space before tabs
https://review.coreboot.org/c/coreboot/+/34505/10/src/mainboard/google/kukui... PS10, Line 36: .lvds_dual_channel = 0, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34505/10/src/mainboard/google/kukui... PS10, Line 36: .lvds_dual_channel = 0, please, no space before tabs
https://review.coreboot.org/c/coreboot/+/34505/10/src/mainboard/google/kukui... PS10, Line 37: .refresh = 60, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34505/10/src/mainboard/google/kukui... PS10, Line 37: .refresh = 60, please, no space before tabs
https://review.coreboot.org/c/coreboot/+/34505/10/src/mainboard/google/kukui... PS10, Line 38: .ha = 1200, .hbl = 164, .hso = 60, .hspw = 24, .hborder = 0, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34505/10/src/mainboard/google/kukui... PS10, Line 38: .ha = 1200, .hbl = 164, .hso = 60, .hspw = 24, .hborder = 0, please, no space before tabs
https://review.coreboot.org/c/coreboot/+/34505/10/src/mainboard/google/kukui... PS10, Line 39: .va = 1920, .vbl = 26, .vso = 14, .vspw = 2, .vborder = 0, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34505/10/src/mainboard/google/kukui... PS10, Line 39: .va = 1920, .vbl = 26, .vso = 14, .vspw = 2, .vborder = 0, please, no space before tabs
https://review.coreboot.org/c/coreboot/+/34505/10/src/mainboard/google/kukui... PS10, Line 40: .phsync = '-', .pvsync = '-', code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34505/10/src/mainboard/google/kukui... PS10, Line 40: .phsync = '-', .pvsync = '-', please, no space before tabs
https://review.coreboot.org/c/coreboot/+/34505/10/src/mainboard/google/kukui... PS10, Line 41: .x_mm = 135, .y_mm = 216, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34505/10/src/mainboard/google/kukui... PS10, Line 41: .x_mm = 135, .y_mm = 216, please, no space before tabs