Attention is currently required from: Martin L Roth.
ron minnich has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80011?usp=email )
Change subject: arch/riscv: Reformat C files with clang-format v16 ......................................................................
Patch Set 1:
(7 comments)
File src/arch/riscv/fit_payload.c:
https://review.coreboot.org/c/coreboot/+/80011/comment/d1411909_3c727011 : PS1, Line 31: printk(BIOS_INFO, "FIT: Leaving additional %u MiB of free space after kernel.\n",
this improvement in readability could be further improved if we allowed reasonable line lengths <duc […]
Done
File src/arch/riscv/opensbi.c:
https://review.coreboot.org/c/coreboot/+/80011/comment/712ea309_94d933b9 : PS1, Line 12: void run_opensbi(const int hart_id, const void *fdt, const void *opensbi, const void *payload,
this is yuck, but, it's the line length we have, so ...
Done
File src/arch/riscv/pmp.c:
https://review.coreboot.org/c/coreboot/+/80011/comment/eb18e8bc_222fd259 : PS1, Line 67: old = read_csr(pmpcfg0);
YAY!
Done
https://review.coreboot.org/c/coreboot/+/80011/comment/9ce055f3_856f8ccc : PS1, Line 204: static pmpcfg_t generate_pmp_napot(uintptr_t base, uintptr_t size, uintptr_t flags)
I'm in heaven here. […]
Done
https://review.coreboot.org/c/coreboot/+/80011/comment/0a2cec25_5ef1c48d : PS1, Line 274: die("Some PMP configurations are locked "
yuck.
Done
File src/arch/riscv/tables.c:
https://review.coreboot.org/c/coreboot/+/80011/comment/3957e19f_b8fdb38e : PS1, Line 15: bootmem_add_range((uintptr_t)_opensbi, REGION_SIZE(opensbi), BM_MEM_OPENSBI);
nice.
Done
File src/arch/riscv/trap_handler.c:
https://review.coreboot.org/c/coreboot/+/80011/comment/0208557a_48b0077e : PS1, Line 36: case 0x00000000:
meh.
Done