Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 )
Change subject: adding new mainboard ported with autoport script ......................................................................
Patch Set 10:
(4 comments)
https://review.coreboot.org/c/coreboot/+/40813/10//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40813/10//COMMIT_MSG@7 PS10, Line 7: adding new mainboard : ported with autoport script Use the imperative, e.g.
mb/ongy/h61m-s1: Add new mainboard
https://review.coreboot.org/c/coreboot/+/40813/10//COMMIT_MSG@13 PS10, Line 13: USB boot (USB 2.0 only - USB 3.0 works sometimes but not always, don't why yet - Works when OS is loaded) Description has a character limit 72 per line.
https://review.coreboot.org/c/coreboot/+/40813/10/src/mainboard/ongy/Kconfig File src/mainboard/ongy/Kconfig:
https://review.coreboot.org/c/coreboot/+/40813/10/src/mainboard/ongy/Kconfig... PS10, Line 1: if VENDOR_ONGY Add a line break here
https://review.coreboot.org/c/coreboot/+/40813/10/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/40813/10/src/mainboard/ongy/h61m-s1... PS10, Line 1: /* : * This program is free software; you can redistribute it and/or : * modify it under the terms of the GNU General Public License as : * published by the Free Software Foundation; version 2 of : * the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */ /* SPDX-License-Identifier: GPL-2.0-only */ /* This file is part of the coreboot project. */