Jeremy Soller has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43612 )
Change subject: ec/system76_ec: add support for System76 EC ......................................................................
Patch Set 14:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43612/14/src/console/console.c File src/console/console.c:
https://review.coreboot.org/c/coreboot/+/43612/14/src/console/console.c@25 PS14, Line 25: __system76_ec_init();
so, why can't this init be done in firmware?
The purpose of this function is to clear the buffer used for the print command. The print command is buffered and only actually outputs characters on a newline or running out of buffer space purely as a performance optimization in coreboot. Therefore, coreboot must clear the buffer when it first gains control of the CPU in order to use this optimization.