Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38743 )
Change subject: nb/intel/haswell/peg: Add PEG driver stub ......................................................................
Patch Set 5:
(4 comments)
Please fix the notes on the commit message. A follow-up can fix the remaining issues with the proprietary windows driver.
https://review.coreboot.org/c/coreboot/+/38743/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38743/5//COMMIT_MSG@17 PS5, Line 17: Windows 10 1909 also tested but generates bluescreen once GPU : driver is loaded.
You might want to dump the vendor DSDT. […]
It's likely looking for ACPI mandatory functions like _DOD, _DSS, ... That should be fixed in a separate commit as it requires reverse engineering the Nvidia driver.
https://review.coreboot.org/c/coreboot/+/38743/5/Documentation/mainboard/len... File Documentation/mainboard/lenovo/t440p.md:
https://review.coreboot.org/c/coreboot/+/38743/5/Documentation/mainboard/len... PS5, Line 61: - dGPU (must be enabled in CMOS options)
Can't it be enabled by default? There's straps to detect its presence.
Usually it's disabled as it draws additional 5Watt in idle
https://review.coreboot.org/c/coreboot/+/38743/5/src/northbridge/intel/haswe... File src/northbridge/intel/haswell/pcie.c:
https://review.coreboot.org/c/coreboot/+/38743/5/src/northbridge/intel/haswe... PS5, Line 42: PEGP
When changing the ASL code, also change this
Done
https://review.coreboot.org/c/coreboot/+/38743/5/src/northbridge/intel/haswe... PS5, Line 53: if (dev->path.pci.devfn == PCI_DEVFN(0, 0) && : port->bus->secondary == 0 && : (port->path.pci.devfn == PCI_DEVFN(1, 0) || : port->path.pci.devfn == PCI_DEVFN(1, 1) || : port->path.pci.devfn == PCI_DEVFN(1, 2))) : return "DEV0";
Yes. As I said, "PEG0 could be". In any case, it's the same thing for these two as well: […]
Done