Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35166 )
Change subject: soc/skl/vr_config: set Iccmax_gt depends on CPU/GT ......................................................................
Patch Set 7:
(4 comments)
Patch Set 6:
(4 comments)
Tested how?
Tested on Asrock motherboard with Core i5-7400 (65W)
https://review.coreboot.org/c/coreboot/+/35166/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35166/6//COMMIT_MSG@7 PS6, Line 7: soc/skl/vr_config: add missed Icc max levels
Maybe: […]
I think a more appropriate commit message is "set Iccmax_gt depends on CPU/GT" I should explain why I use several arguments instead of one
https://review.coreboot.org/c/coreboot/+/35166/6//COMMIT_MSG@26 PS6, Line 26: add
adds
Done
https://review.coreboot.org/c/coreboot/+/35166/6//COMMIT_MSG@27 PS6, Line 27: VR domain
Dot/period at the end please.
Done
https://review.coreboot.org/c/coreboot/+/35166/6/src/soc/intel/skylake/vr_co... File src/soc/intel/skylake/vr_config.c:
https://review.coreboot.org/c/coreboot/+/35166/6/src/soc/intel/skylake/vr_co... PS6, Line 143: VR_CFG_AMP(48),
This should be mentioned in the commit message.
Done