Patch Set 6:

(4 comments)

Tested how?

Tested on Asrock motherboard with Core i5-7400 (65W)

View Change

4 comments:

• Commit Message:

  • Patch Set #6, Line 7: soc/skl/vr_config: add missed Icc max levels

    Maybe: […]

    I think a more appropriate commit message is "set Iccmax_gt depends on CPU/GT"
    I should explain why I use several arguments instead of one

  • Patch Set #6, Line 26: add

    adds

    Done

  • Patch Set #6, Line 27: VR domain

    Dot/period at the end please.

    Done

• File src/soc/intel/skylake/vr_config.c:

  • Patch Set #6, Line 143: VR_CFG_AMP(48),

    This should be mentioned in the commit message.

    Done

To view, visit change 35166. To unsubscribe, or for help writing mail filters, visit settings.