Attention is currently required from: Hung-Te Lin, Jarried Lin.
Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/84932?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/rauru: Configure TPM
......................................................................
Patch Set 9:
(1 comment)
File src/mainboard/google/rauru/bootblock.c:
https://review.coreboot.org/c/coreboot/+/84932/comment/6efb0d7f_b9a102ba?usp... :
PS9, Line 27: IRQ_TYPE_LEVEL_LOW
This should be `IRQ_TYPE_EDGE_RISING`. `IRQ_TYPE_LEVEL_LOW` was a workaround for the buggy EINT driver at the bringup stage.
Please verify the communication between AP and GSC after changing to `IRQ_TYPE_EDGE_RISING`.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84932?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I582f010a9033ccb1771dbb3ccab9f16314628796
Gerrit-Change-Number: 84932
Gerrit-PatchSet: 9
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Comment-Date: Thu, 07 Nov 2024 13:01:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No