Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45969 )
Change subject: [WIP]soc/intel/xeon_sp: Add common chip.h ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45969/3/src/soc/intel/xeon_sp/chip.... File src/soc/intel/xeon_sp/chip.h:
https://review.coreboot.org/c/coreboot/+/45969/3/src/soc/intel/xeon_sp/chip.... PS3, Line 6: chip.h ...
https://review.coreboot.org/c/coreboot/+/45969/3/src/soc/intel/xeon_sp/cpx/c... File src/soc/intel/xeon_sp/cpx/cpx.h:
https://review.coreboot.org/c/coreboot/+/45969/3/src/soc/intel/xeon_sp/cpx/c... PS3, Line 3: #ifndef _SOC_CHIP_H_ Is there a reason why this can't still be called chip.h? (If so, maybe rename the guard?)