18 Aug
2021
18 Aug
'21
7:28 a.m.
Attention is currently required from: Tim Crawford, Jeremy Soller, Benjamin Doron. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43615 )
Change subject: drivers/system76/dgpu: Add driver for System76 switchable graphics ......................................................................
Patch Set 6:
(1 comment)
File src/drivers/system76/dgpu/acpi/dgpu.asl:
https://review.coreboot.org/c/coreboot/+/43615/comment/318d605e_fbdf2d04 PS6, Line 139: CMDR |= 7 This enables Bus Master. I wonder if it's required
--
To view, visit https://review.coreboot.org/c/coreboot/+/43615
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I05833e88457bfc3612cc9a8cbf1eec68dcfc5566
Gerrit-Change-Number: 43615
Gerrit-PatchSet: 6
Gerrit-Owner: Jeremy Soller jeremy@system76.com
Gerrit-Reviewer: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Tim Crawford tcrawford@system76.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Benjamin Doron benjamin.doron00@gmail.com
Gerrit-CC: Michael Niewöhner foss@mniewoehner.de
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Tim Crawford tcrawford@system76.com
Gerrit-Attention: Jeremy Soller jeremy@system76.com
Gerrit-Attention: Benjamin Doron benjamin.doron00@gmail.com
Gerrit-Comment-Date: Wed, 18 Aug 2021 07:28:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment