Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41732 )
Change subject: drivers/vpd: add VPD region VPD_RW_THEN_RO
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/41732/2/src/drivers/vpd/vpd.h
File src/drivers/vpd/vpd.h:
https://review.coreboot.org/c/coreboot/+/41732/2/src/drivers/vpd/vpd.h@11
PS2, Line 11: VPD_RO = 0,
Generally, enums should only use an explict = 0, = 1, etc. when there is some external reason why they need to be exactly this number. Since that's not the case here, I think you should remove that while you're here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41732
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icd7cbd9c3fb2a6b02fc417ad45d7d22ca6795457
Gerrit-Change-Number: 41732
Gerrit-PatchSet: 2
Gerrit-Owner: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 28 May 2020 20:56:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment