Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39615 )
Change subject: sc7180: Add display hardware pipe line initialization ......................................................................
Patch Set 32:
(5 comments)
https://review.coreboot.org/c/coreboot/+/39615/25/src/mainboard/google/trogd... File src/mainboard/google/trogdor/Kconfig:
https://review.coreboot.org/c/coreboot/+/39615/25/src/mainboard/google/trogd... PS25, Line 21: select DRIVERS_TI_SN65DSI86BRIDGE
In the internal patch set submitted, i have updated the order. Not sure , it got missed here.
Well, I mean it's still not fixed. Please talk to Ravi or whoever is in charge of uploading these here and make sure they get ordered correctly the next time.
https://review.coreboot.org/c/coreboot/+/39615/32/src/mainboard/google/trogd... File src/mainboard/google/trogdor/mainboard.c:
https://review.coreboot.org/c/coreboot/+/39615/32/src/mainboard/google/trogd... PS32, Line 8: #include "board.h" Please order the headers with "double quotes" below all the headers with <angled brackets> with a blank line in between. Also, please order headers alphabetically (i.e. most of these should come above <soc/qupv3_config.h>).
https://review.coreboot.org/c/coreboot/+/39615/32/src/mainboard/google/trogd... PS32, Line 93: 200 Note: This number likely needs an update for Pompom (see issuetracker.google.com/issues/161373813). Depending on whether we get the question of exactly how much resolved in time, we can either slip that into this patch or fix it as a follow-up.
https://review.coreboot.org/c/coreboot/+/39615/25/src/soc/qualcomm/sc7180/Ma... File src/soc/qualcomm/sc7180/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/39615/25/src/soc/qualcomm/sc7180/Ma... PS25, Line 65: ramstage-$(CONFIG_MAINBOARD_DO_NATIVE_VGA_INIT) += display/dsi.c
Please put the Makefile lines for each file together with the patch that is adding that file.
Done
https://review.coreboot.org/c/coreboot/+/39615/25/src/soc/qualcomm/sc7180/di... File src/soc/qualcomm/sc7180/display/mdss.c:
https://review.coreboot.org/c/coreboot/+/39615/25/src/soc/qualcomm/sc7180/di... PS25, Line 156: 0x00000003
Where do all these magic numbers come from? This at least needs some comments.
*ping* (still unresolved)