build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37116 )
Change subject: sb/ibexpeak: Use macros instead of hard-coded IDs
......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/37116/2/src/include/device/pci_ids....
File src/include/device/pci_ids.h:
https://review.coreboot.org/c/coreboot/+/37116/2/src/include/device/pci_ids....
PS2, Line 2718: #define PCI_DID_INTEL_IBEXPEAK_LPC_QM57 0x3b07
please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37116/2/src/include/device/pci_ids....
PS2, Line 2719: #define PCI_DID_INTEL_IBEXPEAK_LPC_HM55 0x3b09
please, no space before tabs
https://review.coreboot.org/c/coreboot/+/37116/2/src/include/device/pci_ids....
PS2, Line 2721: #define PCI_DID_INTEL_IBEXPEAK_MOBILE_SATA_AHCI 0x3b29
please, no space before tabs
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37116
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3326f142d483f5008fb2ac878f30c1a3a72f500f
Gerrit-Change-Number: 37116
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 06 Mar 2020 01:10:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment