Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42802 )
Change subject: sb/intel: Fix bad uses of `find_resource`
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42802/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/42802/3//COMMIT_MSG@12
PS3, Line 12: with `probe_resource` instead.
Why not just remove the NULL checking and let things die? Many of those cases seem like the resource they are looking for should absolutely be there.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42802
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I22e2e2ce046cc7ac6f2f2a814d694ff50a8dc89b
Gerrit-Change-Number: 42802
Gerrit-PatchSet: 3
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 25 Jun 2020 15:09:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment