Attention is currently required from: Hung-Te Lin, Jarried Lin, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/86035?usp=email )
Change subject: soc/mediatek: Modify MT6685 pmic driver
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/86035/comment/f100601e_44b22ab3?usp... :
PS1, Line 9: Use mt6685_write8 instead of mt6685_write16 when setting the protect
: key, only need 1 byte needs to be written to the register each time.
When writing key_protect_setting to PMIC, PMIC expects receiving 1 byte per write. PMIC would receive unexpected zero byte if using `mt6685_write16`. Fix the write operation by using mt6685_write8.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86035?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib6e79642e813e7a1f0d38243e9c4db5a699cc9e3
Gerrit-Change-Number: 86035
Gerrit-PatchSet: 1
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Fri, 17 Jan 2025 13:57:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No