Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/em100/+/48584 )
Change subject: Add more traceable SPI commands ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/em100/+/48584/1/trace.c File trace.c:
https://review.coreboot.org/c/em100/+/48584/1/trace.c@108 PS1, Line 108: uses_address
Since this now means something else (it was used as a boolean before), maybe a rename or using an en […]
done
https://review.coreboot.org/c/em100/+/48584/1/trace.c@250 PS1, Line 250: address_mode
I've no idea, but should this be changed to `address_bytes`?
Yep. Thanks.
https://review.coreboot.org/c/em100/+/48584/1/trace.c@281 PS1, Line 281: if (spi_cmd_vals->uses_address) {
Sanity check: does this need to be updated?
Done