Evan Green has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46652 )
Change subject: Revert "mb/google/dedede: Add mainboard acpi support for GPIO PM configuration" ......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/46652/2/src/mainboard/google/dedede... File src/mainboard/google/dedede/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/46652/2/src/mainboard/google/dedede... PS2, Line 42: <soc/intel/common/acpi/lpit.asl>
Do we lose any functionality in the kernel by not exposing LPIT? We won't really use any function no […]
From what I can tell no. We already don't expose an LPIT table, so that's moot. This PNP0D80 device is all that's left. Assuming nothing in firmware land is relying on those ACPI S0 notification methods being called, the only part the kernel would look at is the device constraints in [1]. From what I can see in lpit.asl that's only initialized to a sentinal node now with no real device constraints. So the kernel should be ok.
[1] https://source.corp.google.com/chromeos_public/src/third_party/kernel/v5.4/d...