[coreboot-gerrit] [M] Change in coreboot[main]: vendorcode/amd/opensil/genoa_poc: Implement console callback

[Martin L Roth (Code Review)]

Attention is currently required from: Arthur Heymans.

Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76512?usp=email )

Change subject: vendorcode/amd/opensil/genoa_poc: Implement console callback
......................................................................

Patch Set 5:

(2 comments)

Patchset:

PS4:
> Any objection to me renaming console.h and console.c to opensil_console. […]

I went ahead and renamed them, but I'm going to pause here for any feedback.

File src/vendorcode/amd/opensil/genoa_poc/filter.h:

https://review.coreboot.org/c/coreboot/+/76512/comment/f2208cca_51ee5d6f :
PS5, Line 13: #define SIL_DEBUG(topic) (CONFIG(OPENSIL_DEBUG_##topic) ? DEBUG_FILTER_##topic : 0)
This line triggers an error in the Kconfig linter. I can either exclude it from the linter, or we can just rewrite the SIL_DEBUG values below to not use the macro.

I'd prefer to do the second approach and rewrite the filter, but i figured I'd get other opinions before doing that.