[coreboot-gerrit] Change in coreboot[master]: mb/purism: Don't select NO_POST

[Nico Huber (Code Review)]

Hello Matt DeVillier, Benjamin Doron,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/35956

to review the following change.

Change subject: mb/purism: Don't select NO_POST
......................................................................

mb/purism: Don't select NO_POST

The NO_POST option covers more than classical port 80 output, hence
selecting it seems wrong in this case. The default is still rather
user pratonizing, but let's keep it.

As a side effect, this fixes the ability to override the default
for NO_POST which Kconfig rejected while these boards selected it.
(Seems like a bug in Kconfig, though.)

Change-Id: I896b08812b1aa6ce249d7acc8073ebcc0f72eace
Signed-off-by: Nico Huber 
---
M src/mainboard/purism/librem_bdw/Kconfig
M src/mainboard/purism/librem_skl/Kconfig
2 files changed, 7 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/35956/1

diff --git a/src/mainboard/purism/librem_bdw/Kconfig b/src/mainboard/purism/librem_bdw/Kconfig
index 7f7519c..9424a7e 100644
--- a/src/mainboard/purism/librem_bdw/Kconfig
+++ b/src/mainboard/purism/librem_bdw/Kconfig
@@ -7,7 +7,6 @@
    select HAVE_ACPI_TABLES
    select INTEL_INT15
    select SOC_INTEL_BROADWELL
-	select NO_POST # This platform does not have any way to see POST codes

if BOARD_PURISM_BASEBOARD_LIBREM_BDW

@@ -73,5 +72,8 @@
    default "8086,1616" if BOARD_PURISM_LIBREM13_V1
    default "8086,162b" if BOARD_PURISM_LIBREM15_V2

+# This platform has limited means to display POST codes
+config NO_POST
+	default y

endif
diff --git a/src/mainboard/purism/librem_skl/Kconfig b/src/mainboard/purism/librem_skl/Kconfig
index ecde9e4..cc0e98a 100644
--- a/src/mainboard/purism/librem_skl/Kconfig
+++ b/src/mainboard/purism/librem_skl/Kconfig
@@ -10,7 +10,6 @@
    select MAINBOARD_USES_FSP2_0
    select SPD_READ_BY_WORD
    select MAINBOARD_HAS_LPC_TPM
-	select NO_POST # This platform does not have any way to see POST codes

if BOARD_PURISM_BASEBOARD_LIBREM_SKL

@@ -68,4 +67,8 @@
    hex
    default 0xe00000

+# This platform has limited means to display POST codes
+config NO_POST
+	default y
+
 endif