Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36087 )
Change subject: soc/intel/tigerlake: Do initial SoC commit ......................................................................
Patch Set 10:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36087/10/src/soc/intel/tigerlake/gr... File src/soc/intel/tigerlake/graphics.c:
https://review.coreboot.org/c/coreboot/+/36087/10/src/soc/intel/tigerlake/gr... PS10, Line 53: /* : * GFX PEIM module inside FSP binary is taking care of graphics : * initialization based on INTEL_GMA_ADD_VBT Kconfig : * option and input VBT file. Hence no need to load/execute legacy VGA : * OpROM in order to initialize GFX. : * : * In case of non-FSP solution, SoC need to select VGA_ROM_RUN : * Kconfig to perform GFX initialization through VGA OpRom. : */ : if (CONFIG(INTEL_GMA_ADD_VBT)) : return;
This seems like a bad idea to use a Kconfig option to do something that it is not meant for. […]
Done
https://review.coreboot.org/c/coreboot/+/36532