Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/73851 )
Change subject: mb/google/skyrim: Remove BT power sequencing TODO comment ......................................................................
mb/google/skyrim: Remove BT power sequencing TODO comment
In the first wave of designs, there is only one Bluetooth vendor. Hence there is no need to handle different power sequence requirements.
BUG=None BRANCH=Skyrim TEST=Build Skyrim BIOS image.
Change-Id: Id477dd64de6523d066aa1a5e498381e0bf4b2cc1 Signed-off-by: Karthikeyan Ramasubramanian kramasub@google.com --- M src/mainboard/google/skyrim/variants/baseboard/devicetree.cb 1 file changed, 17 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved
diff --git a/src/mainboard/google/skyrim/variants/baseboard/devicetree.cb b/src/mainboard/google/skyrim/variants/baseboard/devicetree.cb index 6892742..61d22f6 100644 --- a/src/mainboard/google/skyrim/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/skyrim/variants/baseboard/devicetree.cb @@ -174,7 +174,6 @@ register "type" = "UPC_TYPE_INTERNAL" register "has_power_resource" = "true" register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO_10)" - # TODO(b/263161283): Confirm the delay meets the requirement of all BT controllers register "enable_delay_ms" = "500" register "enable_off_delay_ms" = "200" register "use_gpio_for_status" = "true"