build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31898 )
Change subject: tpm: Add API to query TPM presence
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/31898/2/src/drivers/spi/tpm/tpm.c
File src/drivers/spi/tpm/tpm.c:
https://review.coreboot.org/#/c/31898/2/src/drivers/spi/tpm/tpm.c@470
PS2, Line 470: else
else should follow close brace '}'
https://review.coreboot.org/#/c/31898/2/src/security/tpm/tis.h
File src/security/tpm/tis.h:
https://review.coreboot.org/#/c/31898/2/src/security/tpm/tis.h@101
PS2, Line 101: * This function is_tpm_detected() sets tpm_detection value to be 1 upon TPM detection.
line over 80 characters
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31898
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifa7b17085364bb631f43a133839773033721062d
Gerrit-Change-Number: 31898
Gerrit-PatchSet: 2
Gerrit-Owner: nsekar@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: nsekar@codeaurora.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 10 Apr 2019 18:48:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment