[coreboot-gerrit] Change in coreboot[master]: src/soc/intel/common/itss: Add support to get IRQ configuration for P...

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34089 )

Change subject: src/soc/intel/common/itss: Add support to get IRQ configuration for PCI devices
......................................................................

Patch Set 19:

(3 comments)

https://review.coreboot.org/c/coreboot/+/34089/19/src/soc/intel/common/block... 
File src/soc/intel/common/block/itss/irq.c:

https://review.coreboot.org/c/coreboot/+/34089/19/src/soc/intel/common/block... 
PS19, Line 31: alteast
at least

https://review.coreboot.org/c/coreboot/+/34089/19/src/soc/intel/common/block... 
PS19, Line 69: 		printk(BIOS_ERR, "LPSS controller D: 0x%x F: 0x%x uses irq %d"
             : 				", conflicts with gpio mapped to irq %d\n",
             : 				irq_entry->slot, irq_entry->func, int_lpss,
             : 				int_lpss);
Shouldn't we die() with this?  It means there's a fatal configuration error, and I'm assuming that the affected LPSS device's IRQ won't function as expected?

https://review.coreboot.org/c/coreboot/+/34089/19/src/soc/intel/common/block... 
PS19, Line 108: create_irq_entry(dev, &irq_entry);
              : 			irq_config[index] = irq_entry;
You could just do create_irq_entry(dev, &irq_config[index]) to avoid the extra copy