Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47523 )
Change subject: soc/intel/common: Add Kconfig to enable the CSE FW Update feature ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/47523/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47523/3//COMMIT_MSG@10 PS3, Line 10: teh the
https://review.coreboot.org/c/coreboot/+/47523/3//COMMIT_MSG@12 PS3, Line 12: Can you also add a comment here indicating that this is effectively disabling CSE FW update feature for volteer and dedede boards? And that it will be enabled once we transition to the split of data and metadata for CSE RW binary in CBFS.
https://review.coreboot.org/c/coreboot/+/47523/3/src/soc/intel/common/block/... File src/soc/intel/common/block/cse/Kconfig:
https://review.coreboot.org/c/coreboot/+/47523/3/src/soc/intel/common/block/... PS3, Line 45: if SOC_INTEL_CSE_RW_UPDATE This should also cover SOC_INTEL_CSE_FMAP_NAME and SOC_INTEL_CSE_RW_CBFS_NAME. We don't really care about those if we don't need to update CSE.