Attention is currently required from: Naveen M, Paul Menzel, Pranava Y N, Subrata Banik, Varun Upadhyay.
Karthik Ramasubramanian has posted comments on this change by Varun Upadhyay. ( https://review.coreboot.org/c/coreboot/+/85440?usp=email )
Change subject: mb/google/fatcat: Update Soundwire codec address based on devicetree
......................................................................
Patch Set 3:
(2 comments)
File src/mainboard/google/fatcat/variants/fatcat/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/85440/comment/41ab6ded_b4b27353?usp... :
PS3, Line 627: register "alc711_address[1].part_id" = "0x0722"
Move it next to `register register "desc" = ""Headset Codec"` line. There is no probe based DT initialization. All the DT structures are initialized statically. Probe just probes and enables the devices at run-time.
https://review.coreboot.org/c/coreboot/+/85440/comment/d65afef9_e9742b2c?usp... :
PS3, Line 632: register "alc711_address[3].part_id" = "0x0721"
Same comment as above.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85440?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3322ae2d106d3628dbf627aacf999056d82ee7a9
Gerrit-Change-Number: 85440
Gerrit-PatchSet: 3
Gerrit-Owner: Varun Upadhyay
varun.upadhyay@intel.com
Gerrit-Reviewer: Naveen M
naveen.m@intel.com
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Karthik Ramasubramanian
kramasub@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Naveen M
naveen.m@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Varun Upadhyay
varun.upadhyay@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Pranava Y N
pranavayn@google.com
Gerrit-Comment-Date: Mon, 02 Dec 2024 20:26:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No