Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37304 )
Change subject: vboot: Don't perform EC sync in recovery mode
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37304/1/src/security/vboot/ec_sync....
File src/security/vboot/ec_sync.c:
https://review.coreboot.org/c/coreboot/+/37304/1/src/security/vboot/ec_sync....
PS1, Line 60: if (!(ctx->flags & VB2_CONTEXT_RECOVERY_MODE)) {
I was just following the same logic as depthcharge. […]
I agree, I think checking in vboot is cleaner. That is equivalent to VbSelectAndLoadKernel() deciding internally whether to do software sync or not. There are other cases where coreboot/depthcharge need to check directly for recovery mode and that's fine, but in this case I don't think it's necessary.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37304
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifb82396416d6b9af82fc75b3372f8339091469a4
Gerrit-Change-Number: 37304
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 27 Nov 2019 23:58:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment