Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31170 )
Change subject: mb/google/sarien/variants/sarien: Update thermal configuration for DPTF
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/31170/3/src/mainboard/google/sarien/variants...
File src/mainboard/google/sarien/variants/sarien/include/variant/acpi/dptf.asl:
https://review.coreboot.org/#/c/31170/3/src/mainboard/google/sarien/variants...
PS3, Line 16: 99
any reason for keeping this passive 99 ?
If passive is at 99 than I do not see any point of keeping critical at 100. This might shutdown system abruptly in heavy load scenarios. There should be some temperature difference between passive and critical limits. I would suggest to keep passive 95 and keep critical 105.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31170
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I22908e4bf39aedb8cf31a9060084f6f36bff56ca
Gerrit-Change-Number: 31170
Gerrit-PatchSet: 3
Gerrit-Owner: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: Chris Zhou
chris_zhou@compal.corp-partner.google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-Reviewer: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 01 Feb 2019 15:14:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment