Tim Chu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42242 )
Change subject: drivers/ocp/ipmi: Add ipmi set processor information
......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42242/4/src/drivers/ocp/ipmi/ipmi_o...
File src/drivers/ocp/ipmi/ipmi_ocp.h:
https://review.coreboot.org/c/coreboot/+/42242/4/src/drivers/ocp/ipmi/ipmi_o...
PS4, Line 12: #define IPMI_NETFN_OEM_COMMON 0x36
please, no space before tabs
Done
https://review.coreboot.org/c/coreboot/+/42242/4/src/drivers/ocp/ipmi/ipmi_o...
PS4, Line 16: #define MSR_CORE_THREAD_COUNT 0x35
please, no space before tabs
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42242
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3d53ac241a11ca962572816283a0c653fcde9f9e
Gerrit-Change-Number: 42242
Gerrit-PatchSet: 5
Gerrit-Owner: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: Bryant Ou
bryant.ou.q@gmail.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Rocky Phagura
Gerrit-Reviewer: Ryback Hung
ryback.hung%quantatw.com@gtempaccount.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 16 Jun 2020 06:03:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-MessageType: comment