Attention is currently required from: Raul Rangel, Bhanu Prakash Maiya, Karthik Ramasubramanian.
Kenneth Chan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61174 )
Change subject: mb/google/guybrush/var/dewatt: Update touchpad GPIO configuration
......................................................................
Patch Set 4:
(3 comments)
File src/mainboard/google/guybrush/variants/dewatt/gpio.c:
https://review.coreboot.org/c/coreboot/+/61174/comment/42d6ad6b_faf98363
PS3, Line 42: /* SOC_TCHPAD_INT_ODL */
code indent should use tabs where possible
Please fix.
https://review.coreboot.org/c/coreboot/+/61174/comment/24c39e70_4542357c
PS3, Line 43: PAD_SCI(GPIO_9, PULL_NONE, LEVEL_LOW),
code indent should use tabs where possible
Please fix.
https://review.coreboot.org/c/coreboot/+/61174/comment/3b16d097_4d9d8721
PS3, Line 43: PAD_SCI(GPIO_9, PULL_NONE, LEVEL_LOW),
please, no spaces at the start of a line
Please fix.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61174
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I29734595d37283adc6fd4a0ed17f51a5c9061796
Gerrit-Change-Number: 61174
Gerrit-PatchSet: 4
Gerrit-Owner: Kenneth Chan
kenneth.chan@quanta.corp-partner.google.com
Gerrit-Reviewer: Bhanu Prakash Maiya
bhanumaiya@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Bhanu Prakash Maiya
bhanumaiya@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Tue, 25 Jan 2022 08:42:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment