build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40020 )
Change subject: sb/intel/bd82x6x: Tidy up code and comments ......................................................................
Patch Set 1:
(13 comments)
https://review.coreboot.org/c/coreboot/+/40020/1/src/southbridge/intel/bd82x... File src/southbridge/intel/bd82x6x/early_pch.c:
https://review.coreboot.org/c/coreboot/+/40020/1/src/southbridge/intel/bd82x... PS1, Line 144: void early_pch_init_native (void) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40020/1/src/southbridge/intel/bd82x... File src/southbridge/intel/bd82x6x/me_status.c:
https://review.coreboot.org/c/coreboot/+/40020/1/src/southbridge/intel/bd82x... PS1, Line 8: static const char *me_cws_strs[] = { static const char * array should probably be static const char * const
https://review.coreboot.org/c/coreboot/+/40020/1/src/southbridge/intel/bd82x... PS1, Line 19: static const char *me_opstate_strs[] = { static const char * array should probably be static const char * const
https://review.coreboot.org/c/coreboot/+/40020/1/src/southbridge/intel/bd82x... PS1, Line 29: static const char *me_opmode_strs[] = { static const char * array should probably be static const char * const
https://review.coreboot.org/c/coreboot/+/40020/1/src/southbridge/intel/bd82x... PS1, Line 38: static const char *me_error_strs[] = { static const char * array should probably be static const char * const
https://review.coreboot.org/c/coreboot/+/40020/1/src/southbridge/intel/bd82x... PS1, Line 46: static const char *me_progress_strs[] = { static const char * array should probably be static const char * const
https://review.coreboot.org/c/coreboot/+/40020/1/src/southbridge/intel/bd82x... PS1, Line 57: static const char *me_pmevent_strs[] = { static const char * array should probably be static const char * const
https://review.coreboot.org/c/coreboot/+/40020/1/src/southbridge/intel/bd82x... PS1, Line 74: static const char *me_progress_rom_strs[] = { static const char * array should probably be static const char * const
https://review.coreboot.org/c/coreboot/+/40020/1/src/southbridge/intel/bd82x... PS1, Line 80: static const char *me_progress_bup_strs[] = { static const char * array should probably be static const char * const
https://review.coreboot.org/c/coreboot/+/40020/1/src/southbridge/intel/bd82x... PS1, Line 108: static const char *me_progress_policy_strs[] = { static const char * array should probably be static const char * const
https://review.coreboot.org/c/coreboot/+/40020/1/src/southbridge/intel/bd82x... PS1, Line 137: PRINT_ME("ME: Boot Options Present : %s\n", hfs->boot_options_present ? "YES" : "NO"); line over 96 characters
https://review.coreboot.org/c/coreboot/+/40020/1/src/southbridge/intel/bd82x... File src/southbridge/intel/bd82x6x/pch.h:
https://review.coreboot.org/c/coreboot/+/40020/1/src/southbridge/intel/bd82x... PS1, Line 382: #define DIR_ROUTE(x, a, b, c, d) \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/40020/1/src/southbridge/intel/bd82x... File src/southbridge/intel/bd82x6x/pcie.c:
https://review.coreboot.org/c/coreboot/+/40020/1/src/southbridge/intel/bd82x... PS1, Line 277: static const char *names[] = { static const char * array should probably be static const char * const