[coreboot-gerrit] Change in coreboot[master]: src/mainboard: Use 'const' to set pnp_devfn_t statically

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40272 )

Change subject: src/mainboard: Use 'const' to set pnp_devfn_t statically
......................................................................

src/mainboard: Use 'const' to set pnp_devfn_t statically

Change-Id: I50ac6914fadc02491df2eccb437eada89fd12b82
Signed-off-by: Elyes HAOUAS 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/40272
Tested-by: build bot (Jenkins) 
Reviewed-by: Angel Pons 
Reviewed-by: Paul Menzel 
---
M src/mainboard/asus/f2a85-m/bootblock.c
M src/mainboard/getac/p470/early_init.c
M src/mainboard/kontron/ktqm77/early_init.c
M src/mainboard/lenovo/t60/early_init.c
M src/mainboard/lenovo/x60/early_init.c
M src/mainboard/roda/rk886ex/early_init.c
6 files changed, 8 insertions(+), 12 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Paul Menzel: Looks good to me, but someone else must approve
  Angel Pons: Looks good to me, approved

diff --git a/src/mainboard/asus/f2a85-m/bootblock.c b/src/mainboard/asus/f2a85-m/bootblock.c
index c63ab08..4fe0423 100644
--- a/src/mainboard/asus/f2a85-m/bootblock.c
+++ b/src/mainboard/asus/f2a85-m/bootblock.c
@@ -24,8 +24,8 @@

static void superio_init_m(void)
 {
-	pnp_devfn_t uart = PNP_DEV(0x2e, IT8728F_SP1);
-	pnp_devfn_t gpio = PNP_DEV(0x2e, IT8728F_GPIO);
+	const pnp_devfn_t uart = PNP_DEV(0x2e, IT8728F_SP1);
+	const pnp_devfn_t gpio = PNP_DEV(0x2e, IT8728F_GPIO);

ite_kill_watchdog(gpio);
    ite_enable_serial(uart, CONFIG_TTYS0_BASE);
@@ -34,7 +34,7 @@

static void superio_init_m_pro(void)
 {
-	pnp_devfn_t uart = PNP_DEV(0x2e, NCT6779D_SP1);
+	const pnp_devfn_t uart = PNP_DEV(0x2e, NCT6779D_SP1);

nuvoton_enable_serial(uart, CONFIG_TTYS0_BASE);
 }
diff --git a/src/mainboard/getac/p470/early_init.c b/src/mainboard/getac/p470/early_init.c
index cc126dd..04d0c0b 100644
--- a/src/mainboard/getac/p470/early_init.c
+++ b/src/mainboard/getac/p470/early_init.c
@@ -66,9 +66,7 @@

void bootblock_mainboard_early_init(void)
 {
-	pnp_devfn_t dev;
-
-	dev = PNP_DEV(0x4e, 0x00);
+	const pnp_devfn_t dev = PNP_DEV(0x4e, 0x00);

pnp_enter_ext_func_mode(dev);
    pnp_write_config(dev, 0x02, 0x0e); // UART power
diff --git a/src/mainboard/kontron/ktqm77/early_init.c b/src/mainboard/kontron/ktqm77/early_init.c
index 5651064..949eab2 100644
--- a/src/mainboard/kontron/ktqm77/early_init.c
+++ b/src/mainboard/kontron/ktqm77/early_init.c
@@ -35,7 +35,7 @@
 {
    int lvds_3v = 0; /* 0 (5V) or 1 (3V3) */
    int dis_bl_inv = 1; /* backlight inversion: 1 = disabled, 0 = enabled */
-	pnp_devfn_t dev = PNP_DEV(0x2e, 0x9);
+	const pnp_devfn_t dev = PNP_DEV(0x2e, 0x9);
    pnp_enter_conf_state(dev);
    pnp_write_config(dev, 0x29, 0x02); /* Pins 119, 120 are GPIO21, 20 */
    pnp_write_config(dev, 0x30, 0x03); /* Enable GPIO2+3 */
diff --git a/src/mainboard/lenovo/t60/early_init.c b/src/mainboard/lenovo/t60/early_init.c
index dba4c4c..3201102 100644
--- a/src/mainboard/lenovo/t60/early_init.c
+++ b/src/mainboard/lenovo/t60/early_init.c
@@ -22,7 +22,7 @@
 static void early_superio_config(void)
 {
    int timeout = 100000;
-	pnp_devfn_t dev = PNP_DEV(0x2e, 3);
+	const pnp_devfn_t dev = PNP_DEV(0x2e, 3);

pnp_write_config(dev, 0x29, 0xa0);

diff --git a/src/mainboard/lenovo/x60/early_init.c b/src/mainboard/lenovo/x60/early_init.c
index ef760fb..5a8fc78 100644
--- a/src/mainboard/lenovo/x60/early_init.c
+++ b/src/mainboard/lenovo/x60/early_init.c
@@ -22,7 +22,7 @@
 static void early_superio_config(void)
 {
    int timeout = 100000;
-	pnp_devfn_t dev = PNP_DEV(0x2e, 3);
+	const pnp_devfn_t dev = PNP_DEV(0x2e, 3);

pnp_write_config(dev, 0x29, 0x06);

diff --git a/src/mainboard/roda/rk886ex/early_init.c b/src/mainboard/roda/rk886ex/early_init.c
index fe61187..baa17d1 100644
--- a/src/mainboard/roda/rk886ex/early_init.c
+++ b/src/mainboard/roda/rk886ex/early_init.c
@@ -35,9 +35,7 @@

void bootblock_mainboard_early_init(void)
 {
-	pnp_devfn_t dev;
-
-	dev = PNP_DEV(0x2e, 0x00);
+	const pnp_devfn_t dev = PNP_DEV(0x2e, 0x00);

pnp_enter_conf_state(dev);
    pnp_write_config(dev, 0x01, 0x94); /* Extended Parport modes */