Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31376 )
Change subject: mb/google/hatch: Bump up the BIOS region to 28MiB
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31376/1/src/mainboard/google/hatch/chromeos....
File src/mainboard/google/hatch/chromeos.fmd:
https://review.coreboot.org/#/c/31376/1/src/mainboard/google/hatch/chromeos....
PS1, Line 18: 3cffc0
this size increase is almost 1MB, I think it will impact the time for FW hashing.
Currently, I see a boot time impact of ~300usec in vboot verification because of this change.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31376
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5832d2b89c7eedfc270755e2add16131cfbddff4
Gerrit-Change-Number: 31376
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 13 Feb 2019 15:59:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-MessageType: comment