Brandon Breitenstein has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40245 )
Change subject: mainboard/volteer: Update Aux settings for Port 0
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40245/1/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/40245/1/src/mainboard/google/voltee...
PS1, Line 130: 1
I see what you are saying. Humm.. […]
so all 0 works for the ports not being used. however for the port with no retimer there is some inconsistency with functionality when the register is not set to the correct GPIO pad. reverting this back to the original patchset so that IOM can correctly tell SOC which GPIOs to switch for the orientation flip of the cable
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40245
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic81adc24d10322cc305bf0fa4c38514468ea0942
Gerrit-Change-Number: 40245
Gerrit-PatchSet: 5
Gerrit-Owner: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Ma
magf@bitland.com.cn
Gerrit-Comment-Date: Tue, 21 Apr 2020 20:23:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-MessageType: comment