Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44167 )
Change subject: mb/acer/g43t-am3: add Acer G43T-AM3 mainboard
......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44167/8//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/44167/8//COMMIT_MSG@7
PS8, Line 7: mb/acer/g43t-am3: add Acer G43T-AM3 mainboard
Suggestion on IRC was to change the vendor from Acer to ECS because ECS did the board design and Ace […]
I don't care. It can be relocated if someone ports another similar board.
https://review.coreboot.org/c/coreboot/+/44167/8//COMMIT_MSG@11
PS8, Line 11: calls it "G45T/G43T-AM3 V:1.0". In DMI data it is additionally called
Should it be G4xT-AM3 instead?
Unless someone confirms it's the same, I'd just keep the current name
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44167
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I846cf5f4f1ef27fc644676a4c6f7a333e061f6cf
Gerrit-Change-Number: 44167
Gerrit-PatchSet: 8
Gerrit-Owner: Michael Büchler
michael.buechler@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Maciej Matuszczyk
maccraft123mc@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Tue, 22 Sep 2020 02:18:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Büchler
michael.buechler@posteo.net
Gerrit-MessageType: comment