Attention is currently required from: EricR Lai. Ivy Jian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52181 )
Change subject: mb/google/guybrush/var/guybrush: Add FPMCU configration ......................................................................
Patch Set 18:
(4 comments)
File src/mainboard/google/guybrush/bootblock.c:
https://review.coreboot.org/c/coreboot/+/52181/comment/10647287_2cd7abd2 PS14, Line 51: CONFIG(VARIANT_HAS_FPMCU)
Additionally, can you please add a comment here indicating that: "SOC_FP_RST_L line is pulled high w […]
Done
File src/mainboard/google/guybrush/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/52181/comment/c7c3db3b_8e37c0eb PS11, Line 166: early_gpio_table
Looking back at the way things were done for zork, I think we might have to take a similar approach […]
Done
File src/mainboard/google/guybrush/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/52181/comment/cb50f776_6f84394e PS14, Line 238: if (slp_typ != ACPI_S3) {
I think we will have to perform the pad configuration as well here: […]
Done
File src/mainboard/google/guybrush/variants/guybrush/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/52181/comment/107f49f2_3fe18627 PS9, Line 113: register "has_power_resource" = "1"
Can you please probe the signals from reset to see what they look like? […]
Done