Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39857 )
Change subject: mb/google/volteer: Create Malefor variant ......................................................................
Patch Set 6:
(13 comments)
https://review.coreboot.org/c/coreboot/+/39857/5/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/malefor/gpio.c:
https://review.coreboot.org/c/coreboot/+/39857/5/src/mainboard/google/voltee... PS5, Line 10: gpio_table
This table compatible with malefor board, not just a copy.
Thanks! I think the baseboard gpio table needs to be cleaned up so that it is easier to use by variants. Anyways you can start with this for now.
https://review.coreboot.org/c/coreboot/+/39857/6/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/malefor/gpio.c:
https://review.coreboot.org/c/coreboot/+/39857/6/src/mainboard/google/voltee... PS6, Line 83: DN_20K Why?
https://review.coreboot.org/c/coreboot/+/39857/6/src/mainboard/google/voltee... PS6, Line 91: DN_20K Why is this PD added?
https://review.coreboot.org/c/coreboot/+/39857/6/src/mainboard/google/voltee... PS6, Line 101: DN_20K Why PD?
https://review.coreboot.org/c/coreboot/+/39857/6/src/mainboard/google/voltee... PS6, Line 108: DN_20K Same here.
https://review.coreboot.org/c/coreboot/+/39857/6/src/mainboard/google/voltee... PS6, Line 173: DN_20K Same here.
https://review.coreboot.org/c/coreboot/+/39857/6/src/mainboard/google/voltee... PS6, Line 177: DN_20K Same here.
https://review.coreboot.org/c/coreboot/+/39857/6/src/mainboard/google/voltee... PS6, Line 232: DN_20K Why does this have an internal PD?
https://review.coreboot.org/c/coreboot/+/39857/6/src/mainboard/google/voltee... PS6, Line 257: DN_20K Same here.
https://review.coreboot.org/c/coreboot/+/39857/6/src/mainboard/google/voltee... PS6, Line 291: DN_20K Same here.
https://review.coreboot.org/c/coreboot/+/39857/6/src/mainboard/google/voltee... PS6, Line 293: DN_20K and here.
https://review.coreboot.org/c/coreboot/+/39857/6/src/mainboard/google/voltee... PS6, Line 295: DN_20K and here.
https://review.coreboot.org/c/coreboot/+/39857/6/src/mainboard/google/voltee... PS6, Line 348: DN_20K Why?