Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31551 )
Change subject: drivers/intel/fsp1_0: Use new memory clearing API
......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/#/c/31551/5/src/soc/intel/fsp_broadwell_de/romst...
File src/soc/intel/fsp_broadwell_de/romstage/romstage.c:
https://review.coreboot.org/#/c/31551/5/src/soc/intel/fsp_broadwell_de/romst...
PS5, Line 112: if (GetUsableHighMemTop(hob_list_ptr) > 4ULL * GiB)
: highmem_size = GetUsableHighMemTop(hob_list_ptr) - 4ULL * GiB;
: tolm = GetPhysicalLowMemTop(hob_list_ptr);
totally wacky formatting
Done
https://review.coreboot.org/#/c/31551/5/src/soc/intel/fsp_broadwell_de/romst...
PS5, Line 158: if (security_clear_dram_request())
: romstage_clear_mem(hob_list_ptr);
isn't there a more generic piece of code where this could be put in?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31551
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieaac34a9058ee002be71e7089605d80a8b72a3d4
Gerrit-Change-Number: 31551
Gerrit-PatchSet: 6
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Jens Drenhaus
jens.drenhaus@9elements.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Roy Wen
rgzwen@arista.com
Gerrit-Reviewer: York Yang
york.yang@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 04 Mar 2019 14:54:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Gerrit-MessageType: comment