build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27602 )
Change subject: nb/amd/pi/00730F01: use MMIO and performance counters from AGESA ......................................................................
Patch Set 1:
(7 comments)
https://review.coreboot.org/#/c/27602/1/src/northbridge/amd/pi/00730F01/nort... File src/northbridge/amd/pi/00730F01/northbridge.c:
https://review.coreboot.org/#/c/27602/1/src/northbridge/amd/pi/00730F01/nort... PS1, Line 635: ivrs->ivhd.flags |= 0x10; /* Enable ATS support */ line over 80 characters
https://review.coreboot.org/#/c/27602/1/src/northbridge/amd/pi/00730F01/nort... PS1, Line 637: ivrs->ivhd.device_id = 0x2 | (nb_dev->bus->secondary << 8); /* BDF <bus>:00.2 */ line over 80 characters
https://review.coreboot.org/#/c/27602/1/src/northbridge/amd/pi/00730F01/nort... PS1, Line 638: ivrs->ivhd.capability_offset = 0x40; /* Capability block 0x40 (type 0xf, "Secure device") */ line over 80 characters
https://review.coreboot.org/#/c/27602/1/src/northbridge/amd/pi/00730F01/nort... PS1, Line 648: ivrs->ivhd.iommu_feature_info = ivrs_agesa->ivhd.iommu_feature_info & 0x7fe000; line over 80 characters
https://review.coreboot.org/#/c/27602/1/src/northbridge/amd/pi/00730F01/nort... PS1, Line 653: ivrs->ivhd.flags |= 0x10; /* Enable ATS support */ line over 80 characters
https://review.coreboot.org/#/c/27602/1/src/northbridge/amd/pi/00730F01/nort... PS1, Line 655: ivrs->ivhd.device_id = 0x2 | (nb_dev->bus->secondary << 8); /* BDF <bus>:00.2 */ line over 80 characters
https://review.coreboot.org/#/c/27602/1/src/northbridge/amd/pi/00730F01/nort... PS1, Line 656: ivrs->ivhd.capability_offset = 0x40; /* Capability block 0x40 (type 0xf, "Secure device") */ line over 80 characters