Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32708 )
Change subject: mb/gigabyte/ga-b75m-d3{h,v}: Switch to variant setup ......................................................................
Patch Set 7: Code-Review-1
(2 comments)
I would like to see overridetrees instead of two full devicetrees.
https://review.coreboot.org/#/c/32708/7/src/mainboard/gigabyte/ga-panther-po... File src/mainboard/gigabyte/ga-panther-point/Kconfig:
https://review.coreboot.org/#/c/32708/7/src/mainboard/gigabyte/ga-panther-po... PS7, Line 51: config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID : hex : default 0x5001 : : config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID : hex : default 0x1458 AFAIK these are unused and could be dropped.
They also do not seem to be on the original Kconfig files for either board. Since the diff does not show them side-by-side, I almost missed this.
https://review.coreboot.org/#/c/32708/7/src/mainboard/gigabyte/ga-panther-po... PS7, Line 63: config VGA_BIOS_ID : string : default "8086,0162" : : config VGA_BIOS_FILE : string : default "pci8086,0162.rom" Setting these values on a socketed board does not make sense and they should be dropped. The iGPU is in the CPU and it is not predictable.