I would like to see overridetrees instead of two full devicetrees.
Patch set 7:Code-Review -1
2 comments:
File src/mainboard/gigabyte/ga-panther-point/Kconfig:
config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID
hex
default 0x5001
config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID
hex
default 0x1458
AFAIK these are unused and could be dropped.
They also do not seem to be on the original Kconfig files for either board. Since the diff does not show them side-by-side, I almost missed this.
config VGA_BIOS_ID
string
default "8086,0162"
config VGA_BIOS_FILE
string
default "pci8086,0162.rom"
Setting these values on a socketed board does not make sense and they should be dropped. The iGPU is in the CPU and it is not predictable.
To view, visit change 32708. To unsubscribe, or for help writing mail filters, visit settings.