Attention is currently required from: Yu-Ping Wu.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64547 )
Change subject: Makefile.inc: Add bootblock to CBFS before others
......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/64547/comment/c068e757_9cbc2190
PS2, Line 9: cbfstool
The problem is that it still needs to be updated again every time a new CBFS file is added. We want images where even after the coreboot build system is done with them, you can still run `cbfstool add` to put more files in them (e.g. an out-of-tree payload) without breaking the verification chain. I think the only way that can work is if cbfstool knows how to find and update the bootblock in place, wherever it is on each platform.
Any thoughts on how to solve this?
cbfstool would need to detect whether the bootblock is inside IFWI (Intel) or PSP firmware (AMD) and have capabilities to extract it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/64547
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I385deb8231e44310ee139c3f69f449e75b92b2be
Gerrit-Change-Number: 64547
Gerrit-PatchSet: 4
Gerrit-Owner: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin L Roth
gaumless@tutanota.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Hung-Te Lin
hungte@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Wed, 01 Jun 2022 07:12:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment