[coreboot-gerrit] Change in coreboot[master]: ec/lenovo/h8: Make dock init in ramstage fully mainboard-specific

[Bill XIE (Code Review)]

Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36385 )

Change subject: ec/lenovo/h8: Make dock init in ramstage fully mainboard-specific
......................................................................

Patch Set 10:
> Patch Set 10:
> > Patch Set 10:
> > > Patch Set 10:
> > >
> > > This commit caused a regression on the Lenovo X201.
> > >
> > > https://ticket.coreboot.org/issues/256
> >
> > What is the cause of this? Is init_dock() called before h8 is enabled?
>
> Probably. If I understand things right, mainboard_enable is called quite early during wakeup, whereas the h8 stuff happens much later (assuming that the order in the device tree is relevant and also assuming that I'm reading it correctly).

You could try CB:39708 after it passes basic build tests.