Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47310 )
Change subject: mb/google/zork: Add finalize GPIO routine ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47310/3/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/berknip/gpio.c:
https://review.coreboot.org/c/coreboot/+/47310/3/src/mainboard/google/zork/v... PS3, Line 65: need an extra delay here
I think the change should be self-sufficient without a need to go back to bug to understand it. […]
I've posted this comment on the bug. I was specifically asked to make sure we DID reset the fpmcu, even on old boards.
As discussed in the previous commit, I'm going to combine this commit with the previous one. I'm currently leaving this code as it is until it's confirmed which way to go.