Stanley Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47009 )
Change subject: mb/google/volteer/variant/lindar: change speaker smart amplifier to ALC1011
......................................................................
Patch Set 9:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47009/8//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/47009/8//COMMIT_MSG@7
PS8, Line 7: b
mb?
Yes, already correct as mb.
https://review.coreboot.org/c/coreboot/+/47009/8/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/47009/8/src/mainboard/google/voltee...
PS8, Line 18: RT1011_ALC5682I_I2S
Let me add you to review the CL.
Zhuohao already added you in reviewer on CP:3402465
Thanks, Zhuohao.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47009
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4d83a19b3baa87cc926bb7c3a2cb96bf3165d2f4
Gerrit-Change-Number: 47009
Gerrit-PatchSet: 9
Gerrit-Owner: Stanley Wu
stanley1.wu@lcfc.corp-partner.google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@chromium.org
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Allen Cheng
allen.cheng@lcfc.corp-partner.google.com
Gerrit-CC: Jerry2 Huang
jerry2.huang@lcfc.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Rasheed Hsueh
rasheed.hsueh@lcfc.corp-partner.google.com
Gerrit-CC: Sunshine Chao
sunshine.chao@lcfc.corp-partner.google.com
Gerrit-Comment-Date: Wed, 18 Nov 2020 03:40:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Caveh Jalali
caveh@chromium.org
Comment-In-Reply-To: Zhuohao Lee
zhuohao@google.com
Gerrit-MessageType: comment