chris wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43408 )
Change subject: mb/google/zork: add dptc support ......................................................................
Patch Set 11:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43408/9/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/dptc.asl:
https://review.coreboot.org/c/coreboot/+/43408/9/src/mainboard/google/zork/v... PS9, Line 29: If (_SB.PCI0.LPCB.EC0.RCTM == One) {
Please add comments indicating what each method is for.
Done
https://review.coreboot.org/c/coreboot/+/43408/9/src/mainboard/google/zork/v... PS9, Line 37: POF0
These methods don't do anything? What is the purpose of these methods? And why is this file in mainb […]
The dptc should used for specific project design, so move it on the board layer. the project which need specific power parameter via dptc, it need implement in variant/dptc.asl