Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40592 )
Change subject: drivers/intel/gma: put controller in separate header
......................................................................
Patch Set 7: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/40592/5//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/40592/5//COMMIT_MSG@10
PS5, Line 10: along all of i915_reg.h
what do you propose here? or something for a follow on patch?
Follow up, if you want. These cleanups never end... I only noticed
that we could as well have removed the `#include <i915_reg.h>` from
`i915.h`. The latter is just overall messy.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40592
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I73fb7ef01abaafdcdbc44f1e3f5eb1883fc31616
Gerrit-Change-Number: 40592
Gerrit-PatchSet: 7
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 25 Apr 2020 23:43:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Gerrit-MessageType: comment