Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34235 )
Change subject: soc/rockchip/rk3288/include/soc: Add missing include <stddef.h>
......................................................................
Patch Set 1: -Code-Review
(1 comment)
https://review.coreboot.org/c/coreboot/+/34235/1/src/soc/rockchip/rk3288/inc...
File src/soc/rockchip/rk3288/include/soc/sdram.h:
https://review.coreboot.org/c/coreboot/+/34235/1/src/soc/rockchip/rk3288/inc...
PS1, Line 28: u8
Actually, all of these need <stdint.h> too. So why not just add <types.h> instead?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34235
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibde48d7cff582c91f55ad5f1328aac64d018b3c5
Gerrit-Change-Number: 34235
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 11 Jul 2019 17:16:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment