Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30987 )
Change subject: mb/asus: Add Asus A88XM-E FM2+ with documentation
......................................................................
Patch Set 83: Code-Review+2
(3 comments)
https://review.coreboot.org/c/coreboot/+/30987/80/src/mainboard/asus/a88xm-e...
File src/mainboard/asus/a88xm-e/buildOpts.c:
PS80:
This file can be cleaned up *a lot*
Done
https://review.coreboot.org/c/coreboot/+/30987/82/src/mainboard/asus/a88xm-e...
File src/mainboard/asus/a88xm-e/buildOpts.c:
https://review.coreboot.org/c/coreboot/+/30987/82/src/mainboard/asus/a88xm-e...
PS82, Line 33: MOBILE
Interesting
Done
https://review.coreboot.org/c/coreboot/+/30987/82/src/mainboard/asus/a88xm-e...
PS82, Line 55: f2a85_m
I don't think so
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30987
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I60fa0636ba41f5f1a6a3faa2764bf2f0a968cf90
Gerrit-Change-Number: 30987
Gerrit-PatchSet: 83
Gerrit-Owner: Balázs Vinarz
vinibali1@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Balázs Vinarz
vinibali1@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 06 Aug 2020 17:59:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment